Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch F90 format checker to fprettify. #1097

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Switch F90 format checker to fprettify. #1097

merged 1 commit into from
Aug 5, 2021
+242 −403

Conversation

KineticTheory
Copy link
Collaborator

@KineticTheory KineticTheory commented Aug 5, 2021 •
edited by brryan
Loading

Background

  • Adopt a more robust F90 format checker.

Purpose of Pull Request

Description of changes

  • Update CI and git hook scripts.
  • Remvoe old emacs-based checker.

Status

@KineticTheory KineticTheory added this to the Draco-7_12_0 milestone Aug 5, 2021
@KineticTheory KineticTheory self-assigned this Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #1097 (1c8f037) into develop (f78ab08) will decrease coverage by 2.9%.
The diff coverage is n/a.

❗ Current head 1c8f037 differs from pull request most recent head 7e811c0. Consider uploading reports for the commit 7e811c0 to get more accurate results

@@            Coverage Diff            @@
##           develop   #1097     +/-   ##
=========================================
- Coverage     88.7%   85.7%   -3.0%     
=========================================
  Files          374     356     -18     
  Lines        18593   17227   -1366     
=========================================
- Hits         16497   14776   -1721     
- Misses        2096    2451    +355

@KineticTheory
Switch F90 format checker to fprettify.
7e811c0 
+ Update CI and git hook scripts.
+ Remvoe old emacs-based checker.
@attom
Copy link
Contributor

attom commented Aug 5, 2021

Thanks for doing this, KT. I know I tend to turn off the current f90 checker because it mucks with everything (I think some of our line lengths are bad)

brryan
brryan approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this @KineticTheory, improved fortran formatting will be a big help (even if fprettify didn't seem to have quite all the features I personally wanted when I last looked at it, mainly splitting up lines, although it did seem to be the best of all available options).

@brryan brryan merged commit 5fa07a9 into lanl:develop Aug 5, 2021
@KineticTheory
Copy link
Collaborator Author

KineticTheory commented Aug 5, 2021 •
edited
Loading

LGTM! Thanks for doing this @KineticTheory, improved fortran formatting will be a big help (even if fprettify didn't seem to have quite all the features I personally wanted when I last looked at it, mainly splitting up lines, although it did seem to be the best of all available options).

We are using version 0.3.6. v0.3.7 is available. Let me know if any of these features make it worthwhile to upgrade our installations.

@KineticTheory KineticTheory deleted the fprettify branch August 5, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brryan brryan brryan approved these changes

Assignees

@KineticTheory KineticTheory

Labels
dev-env
Projects
None yet
Milestone
Draco-7_12_0
Development

Successfully merging this pull request may close these issues.
3 participants
@KineticTheory @attom @brryan